MIGRATION.md (1)

194-244: 💤 Low value

Comprehensive guide for creating test mocks.

The examples clearly demonstrate the shift from class instantiation to typed object literals. The code is syntactically correct and the imports align with the updated module structure.

One consideration: The getCallbackOfType implementation at line 218 throws an error with "not implemented". While this is appropriate for a minimal mock example in tests/stories, consider adding a brief note that production code or more complete test fixtures would need full implementations of all methods.

📝 Suggested clarification

Add a note after line 225 or in the introduction paragraph at line 196:

 const mockStep: JourneyStep = {
   type: StepType.Step,
   payload: rawPayload,
   callbacks: rawPayload.callbacks?.map(createCallback) ?? [],
   getCallbackOfType: (type) => {
     throw new Error('not implemented');
   },
   getCallbacksOfType: (type) => [],
   setCallbackValue: () => {},
   getDescription: () => undefined,
   getHeader: () => undefined,
   getStage: () => undefined,
 };
+
+// Note: This is a minimal mock suitable for stories and basic tests.
+// Production code or comprehensive test fixtures should implement all methods fully.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@MIGRATION.md` around lines 194 - 244, Add a short clarifying note near the
mock examples (around the mockStep/mockSuccess/mockFailure block) explaining
that the provided JourneyStep/JourneyLoginSuccess/JourneyLoginFailure object
literals are minimal test stubs and that getCallbackOfType currently throws
("not implemented") as a placeholder; recommend implementing full method
behavior (e.g., getCallbackOfType, getCallbacksOfType, setCallbackValue, etc.)
for production code or more comprehensive test fixtures so readers know when to
replace the placeholder with real logic.